Support custom exception handling #14493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
🔧 The result from spotlessApply was committed to the PR branch. |
laurit
reviewed
Aug 22, 2025
zeitlinger
approved these changes
Aug 22, 2025
laurit
reviewed
Aug 22, 2025
| StringWriter writer = new StringWriter(); | ||
| throwable.printStackTrace(new PrintWriter(writer)); | ||
| attributes.put(ExceptionAttributes.EXCEPTION_STACKTRACE, writer.toString()); | ||
| if (builder instanceof ExtendedLogRecordBuilder) { |
Contributor
There was a problem hiding this comment.
https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/conventions/src/main/kotlin/io.opentelemetry.instrumentation.library-instrumentation.gradle.kts adds dependency to instrumentation-api-incubator that pulls in opentelemetry-api-incubator so ExtendedLogRecordBuilder is always present. Really this instrumentation doesn't use the instrumentation api.
trask
force-pushed
the
support-custom-exception-handling
branch
2 times, most recently
from
380f60f to
2e553f7
Compare
Contributor
|
🔧 The result from spotlessApply was committed to the PR branch. |
trask
force-pushed
the
support-custom-exception-handling
branch
from
4544a29 to
40c7dd3
Compare
Contributor
|
🔧 The result from spotlessApply was committed to the PR branch. |
laurit
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14485